New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not eat get/set after async is parsed #11916
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26866/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5d62959:
|
We should release this PR later today |
Save us :D |
@@ -1754,7 +1754,7 @@ export default class ExpressionParser extends LValParser { | |||
} | |||
// get PropertyName[?Yield, ?Await] () { FunctionBody[~Yield, ~Await] } | |||
// set PropertyName[?Yield, ?Await] ( PropertySetParameterList ) { FunctionBody[~Yield, ~Await] } | |||
if (prop.key.name === "get" || prop.key.name === "set") { | |||
else if (prop.key.name === "get" || prop.key.name === "set") { | |||
isAccessor = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 4 unnecessary member access. 2 unnecessary function call here that slow down on performance. Also 2x string comparison. No plans to optimize it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will address in another PR: #11918.
Fixed a regression introduced in #11871. When
async
is consumed, we should not unintentionally eatset
/get
because async accessor is not a thing in the spec.